Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the ImportError occuring on urllib #810

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix the ImportError occuring on urllib #810

merged 1 commit into from
Jul 13, 2023

Conversation

ArtyomVancyan
Copy link
Contributor

@ArtyomVancyan ArtyomVancyan commented Jul 12, 2023 •
edited
Loading

Proposed changes

The issue that was fixed in this PR has been described in the #811 issue. In short, it fixes the ImportError that occurs when importing the nk backend.

Types of changes

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@ArtyomVancyan ArtyomVancyan mentioned this pull request Jul 12, 2023
Closed
@nijel
Copy link
Member

nijel commented Jul 13, 2023

Thanks! Are you willing to write tests for this backend, so that it is tested in our CI pipeline?

@nijel nijel linked an issue Jul 13, 2023 that may be closed by this pull request
ImportError: cannot import name 'urlencode' from 'urllib' #811
Closed
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #810 (99611af) into master (d0946f5) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files         330      330           
  Lines       10093    10093           
  Branches     1194     1194           
=======================================
  Hits         7854     7854           
  Misses       2086     2086           
  Partials      153      153
Flag Coverage Δ
unittests 77.81% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
social_core/backends/nk.py 0.00% <0.00%> (ø)

@nijel nijel merged commit 037f8fa into python-social-auth:master Jul 13, 2023
@nijel
Copy link
Member

nijel commented Jul 13, 2023

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'urlencode' from 'urllib'
2 participants
@ArtyomVancyan @nijel